Refine assert IPEX #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
EikanWang
commented
May 20, 2020
| @@ -305,11 +305,11 @@ inline std::vector<at::Tensor> _interaction_backward(const at::Tensor & grad_out | |||
|
|
|||
| at::Tensor AtenIpexTypeExt::interaction_forward(const std::vector<at::Tensor> & input) { | |||
| if (input[0].scalar_type() == at::kFloat) { | |||
| for (const auto &in : input) { TORCH_INTERNAL_ASSERT(in.scalar_type() == at::kFloat); } | |||
There was a problem hiding this comment.
@hongzhen1 , Do you think it should be replaced by TORCH_CHECK?
zhuhaozhe
pushed a commit
to zhuhaozhe/intel-extension-for-pytorch
that referenced
this pull request
Apr 23, 2021
add dlrm op bench (using pytorch op bench)
EikanWang
pushed a commit
that referenced
this pull request
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TORCH_INTERNAL_ASSERT is not only for debug but also for release. I replaced it by TORCH_INTERNAL_ASSERT_DEBUG_ONLY. TORCH_INTERNAL_ASSERT_DEBUG_ONLY is only enabled in debug.